Examples updated to match MTK v9 macros syntax #16
+667
−1,063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated examples to match MTK v9 macros syntax
|
@bradcarman Just following up here? |
|
Yeah, I think this looks good. Can you just remove Revise from the Project.toml? I don't think it needs to be there. |
Removed Revise from Project.toml
|
@bradcarman Done |
|
@bradcarman Just following up here? |
|
Hi @matthew-kapp this looks good, I'll approve. Thanks for your contribution! |
|
@bradcarman sorry, I'm still learning git approvals - is there still a final step to merge merge request? |
|
Sorry, I was just waiting for tests to pass, all merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples have been updated in such a way that the exact same model is created, but the syntax matches that used by MTK v9, where @mtkmodel and other macros are used.